From dbda1132df1a90bdbdaf0d2f474ab81090aedc6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Cocula?= Date: Sat, 31 Dec 2016 19:55:02 +0100 Subject: [PATCH] rest API migration (WIP) + fixes. --- .../player/controller/PlaylistController.java | 2 +- .../PodcastReceiverAdminController.java | 2 +- .../player/controller/RESTController.java | 6 ++--- .../webapp/WEB-INF/jsp/podcastChannels.jsp | 4 ++-- .../libresonic-rest-api-soapui-project.xml | 22 ++++++++++++------- 5 files changed, 21 insertions(+), 15 deletions(-) diff --git a/libresonic-main/src/main/java/org/libresonic/player/controller/PlaylistController.java b/libresonic-main/src/main/java/org/libresonic/player/controller/PlaylistController.java index aa950fd3..386b36df 100644 --- a/libresonic-main/src/main/java/org/libresonic/player/controller/PlaylistController.java +++ b/libresonic-main/src/main/java/org/libresonic/player/controller/PlaylistController.java @@ -79,7 +79,7 @@ public class PlaylistController { map.put("editAllowed", username.equals(playlist.getUsername()) || securityService.isAdmin(username)); map.put("partyMode", userSettings.isPartyModeEnabled()); - return new ModelAndView("playList","model",map); + return new ModelAndView("playlist","model",map); } diff --git a/libresonic-main/src/main/java/org/libresonic/player/controller/PodcastReceiverAdminController.java b/libresonic-main/src/main/java/org/libresonic/player/controller/PodcastReceiverAdminController.java index f3b19093..579ef30a 100644 --- a/libresonic-main/src/main/java/org/libresonic/player/controller/PodcastReceiverAdminController.java +++ b/libresonic-main/src/main/java/org/libresonic/player/controller/PodcastReceiverAdminController.java @@ -47,7 +47,7 @@ public class PodcastReceiverAdminController { @Autowired private PodcastService podcastService; - @RequestMapping(method = RequestMethod.GET) + @RequestMapping(method = RequestMethod.POST) protected ModelAndView handleRequestInternal(HttpServletRequest request, HttpServletResponse response) throws Exception { Integer channelId = ServletRequestUtils.getIntParameter(request, "channelId"); diff --git a/libresonic-main/src/main/java/org/libresonic/player/controller/RESTController.java b/libresonic-main/src/main/java/org/libresonic/player/controller/RESTController.java index 42c07d7d..d9933700 100644 --- a/libresonic-main/src/main/java/org/libresonic/player/controller/RESTController.java +++ b/libresonic-main/src/main/java/org/libresonic/player/controller/RESTController.java @@ -263,7 +263,7 @@ public class RESTController { jaxbWriter.writeResponse(request, response, res); } - @SuppressWarnings("UnusedDeclaration") + @RequestMapping(value = "/rest/getSongsByGenre", method = RequestMethod.GET) public void getSongsByGenre(HttpServletRequest request, HttpServletResponse response) throws Exception { request = wrapRequest(request); Player player = playerService.getPlayer(request, response); @@ -754,7 +754,7 @@ public class RESTController { jaxbWriter.writeResponse(request, response, res); } - @SuppressWarnings("UnusedDeclaration") + @RequestMapping(value = "/rest/getPlaylists", method = RequestMethod.GET) public void getPlaylists(HttpServletRequest request, HttpServletResponse response) throws Exception { request = wrapRequest(request); @@ -1500,7 +1500,7 @@ public class RESTController { jaxbWriter.writeResponse(request, response, res); } - @SuppressWarnings("UnusedDeclaration") + @RequestMapping(value = "/rest/getPodcasts", method = RequestMethod.GET) public void getPodcasts(HttpServletRequest request, HttpServletResponse response) throws Exception { request = wrapRequest(request); Player player = playerService.getPlayer(request, response); diff --git a/libresonic-main/src/main/webapp/WEB-INF/jsp/podcastChannels.jsp b/libresonic-main/src/main/webapp/WEB-INF/jsp/podcastChannels.jsp index 12bf2f18..7445803c 100644 --- a/libresonic-main/src/main/webapp/WEB-INF/jsp/podcastChannels.jsp +++ b/libresonic-main/src/main/webapp/WEB-INF/jsp/podcastChannels.jsp @@ -99,7 +99,7 @@ -
+ @@ -107,7 +107,7 @@
"/>
- +
diff --git a/libresonic-main/src/test/resources/libresonic-rest-api-soapui-project.xml b/libresonic-main/src/test/resources/libresonic-rest-api-soapui-project.xml index 3e1096e4..09f1625c 100755 --- a/libresonic-main/src/test/resources/libresonic-rest-api-soapui-project.xml +++ b/libresonic-main/src/test/resources/libresonic-rest-api-soapui-project.xml @@ -1,18 +1,24 @@ -http://localhost:8080/ujoeQUERYjoepsesameQUERYsesamev1.12.0QUERY1.12.0cmyappQUERYmyapptext/xml; charset=utf-8200res:subsonic-responsetext/html; charset=iso-8859-1404html0data0data0data0data<xml-fragment/>http://192.168.0.11:4040http://192.168.0.11/rest/ping.viewNo Authorization - - -upvcujoeQUERYjoepsesameQUERYsesamev1.12.0QUERY1.12.0cmyappQUERYmyappincludeEpisodesQUERYuremiQUERYremipMozart*1QUERYMozart*1v1.2.0QUERY1.2.0cmyappQUERYmyappincludeEpisodesfalseQUERYfalsetext/xml; charset=utf-8200res:subsonic-responsetext/html; charset=iso-8859-1404html0data<xml-fragment/>http://192.168.0.11:4040http://192.168.0.11/rest/ping.viewNo Authorization +http://localhost:8080/uadminQUERYadminpadminQUERYadminv1.13.0QUERY1.13.0csoapuiQUERYsoapuitext/xml; charset=utf-8200res:subsonic-responsetext/html; charset=iso-8859-1404html0data0data0data0datatext/xml;charset=UTF-8200res:subsonic-response<xml-fragment/>http://localhost:8080/http://192.168.0.11/rest/ping.viewNo AuthorizationupvcuadminQUERYadminpadminQUERYadminv1.13.0QUERY1.13.0csoapuiQUERYsoapuiincludeEpisodesQUERYidQUERYuremiQUERYremipMozart*1QUERYMozart*1v1.2.0QUERY1.2.0cmyappQUERYmyappincludeEpisodesfalseQUERYfalsetext/xml; charset=utf-8200res:subsonic-responsetext/html; charset=iso-8859-1404html0datatext/xml;charset=UTF-8200res:subsonic-response<xml-fragment/>http://localhost:8080/http://192.168.0.11/rest/ping.viewNo Authorization + - - -upvcincludeEpisodesuremiQUERYremipMozart*1QUERYMozart*1v1.2.0QUERY1.2.0cmyappQUERYmyappincludeEpisodestrueQUERYtrueidQUERYtext/xml; charset=utf-8200res:subsonic-response<xml-fragment/>http://192.168.0.11:4040http://192.168.0.11/rest/getPodcasts.viewNo Authorization<xml-fragment/>http://192.168.0.11:4040http://192.168.0.11/rest/getPodcasts.viewNo AuthorizationuadminQUERYadminpadminQUERYadminv1.13.0QUERY1.13.0csoapuiQUERYsoapuitypeQUERYsizeQUERYoffsetQUERYfromYearQUERYtoYearQUERYgenreQUERYmusicFolderIdQUERYapplication/json;charset=UTF-8500get:Faulttext/xml;charset=UTF-8200res:subsonic-response<xml-fragment/>http://localhost:8080/http://localhost/rest/getAlbumList.viewNo Authorization + + + +upvcincludeEpisodes<xml-fragment/>http://localhost:8080/http://192.168.0.11/rest/ping.viewNo Authorization + + + + + + +upvcincludeEpisodesuadminQUERYadminpadminQUERYadminv1.13.0QUERY1.13.0csoapuiQUERYsoapuitypeQUERYsizeQUERYoffsetQUERYfromYearQUERYtoYearQUERYgenreQUERYmusicFolderIdQUERYapplication/json;charset=UTF-8500get:Faulttext/xml;charset=UTF-8200res:subsonic-response<xml-fragment/>http://localhost:8080/http://localhost/rest/getAlbumList.viewNo Authorization uadmiQUERYadmipadminQUERYadminv1.13.0QUERY1.13.0csoapuiQUERYsoapuisizeQUERYgenreQUERYfromYearQUERYtoYearQUERYmusicFolderIdQUERYuadminQUERYadminpadminQUERYadminv1.13.0QUERY1.13.0csoapuiQUERYsoapuitypeQUERYsizeQUERYoffsetQUERYfromYearQUERYtoYearQUERYgenreQUERYmusicFolderIdQUERYtext/xml; charset=utf-8200res:subsonic-response0datatext/xml;charset=UTF-8200res:subsonic-response<xml-fragment/>http://localhost:8080/http://192.168.0.11/rest/getAlbumList.viewNo Authorization -upvctypesizeoffsetfromYeartoYeargenremusicFolderIdujoeQUERYjoepsesameQUERYsesamev1.12.0QUERY1.12.0cmyappQUERYmyappgenreQUERYcountQUERYoffsetQUERYmusicFolderIdQUERYtext/xml; charset=utf-8200res:subsonic-response0data0data0data0data0datatext/html; charset=iso-8859-1503html0data0data0data0data<xml-fragment/>http://localhost:8080/testResthttp://192.168.0.11/rest/getSongsByGenre.viewNo Authorization +upvctypesizeoffsetfromYeartoYeargenremusicFolderIduadminQUERYadminpadminQUERYadminv1.13.0QUERY1.13.0csoapuiQUERYsoapuigenreQUERYcountQUERYoffsetQUERYmusicFolderIdQUERYtext/xml; charset=utf-8200res:subsonic-response0data0data0data0data0datatext/html; charset=iso-8859-1503html0data0data0data0datatext/xml;charset=UTF-8200res:subsonic-response<xml-fragment/>http://localhost:8080/http://192.168.0.11/rest/getSongsByGenre.viewNo Authorization