From 3d8f3ed21dc9fde86726c77de33da30e6931ab96 Mon Sep 17 00:00:00 2001 From: jvoisin Date: Thu, 19 Sep 2019 19:54:58 +0000 Subject: [PATCH] Gracefully handle failed version check attempts This issue what found by darkling, and reported on irc --- .../main/java/org/airsonic/player/service/VersionService.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/airsonic-main/src/main/java/org/airsonic/player/service/VersionService.java b/airsonic-main/src/main/java/org/airsonic/player/service/VersionService.java index 813bb408..208d2c28 100644 --- a/airsonic-main/src/main/java/org/airsonic/player/service/VersionService.java +++ b/airsonic-main/src/main/java/org/airsonic/player/service/VersionService.java @@ -25,6 +25,7 @@ import org.apache.commons.io.IOUtils; import org.apache.http.client.ResponseHandler; import org.apache.http.client.config.RequestConfig; import org.apache.http.client.methods.HttpGet; +import org.apache.http.conn.ConnectTimeoutException; import org.apache.http.impl.client.BasicResponseHandler; import org.apache.http.impl.client.CloseableHttpClient; import org.apache.http.impl.client.HttpClients; @@ -243,6 +244,9 @@ public class VersionService { try (CloseableHttpClient client = HttpClients.createDefault()) { ResponseHandler responseHandler = new BasicResponseHandler(); content = client.execute(method, responseHandler); + } catch (ConnectTimeoutException e) { + LOG.warn("Got a timeout when trying to reach {}", VERSION_URL); + return; } List unsortedTags = JsonPath.read(content, JSON_PATH);